Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tarballs contain specific attributes on '.' #5252

Closed
raggi opened this issue Jan 2, 2016 · 5 comments
Closed

Release tarballs contain specific attributes on '.' #5252

raggi opened this issue Jan 2, 2016 · 5 comments
Assignees

Comments

@raggi
Copy link

raggi commented Jan 2, 2016

You cannot unpack the release tarballs blindly without having side effects on your system, for example:

tar: .: Cannot utime: Operation not permitted
tar: .: Cannot change mode to rwx------: Operation not permitted
tar: Exiting with failure status due to previous errors

For now I'd recommend users do:

tar zxf influxdb_0.9.6.1_x86_64.tar.gz ./influxdb_0.9.6.1_x86_64/

But that shouldn't be necessary.

Thanks!

@rossmcdonald
Copy link
Contributor

@raggi What command did you run to get the original error output? I've attempted to recreate the issue here (both Mac and Linux):

$ curl -sLO http://influxdb.s3.amazonaws.com/influxdb_0.9.6.1_x86_64.tar.gz
$ tar -xvf influxdb_0.9.6.1_x86_64.tar.gz
x ./
x ./influxdb_0.9.6.1_x86_64/
x ./influxdb_0.9.6.1_x86_64/usr/
x ./influxdb_0.9.6.1_x86_64/usr/bin/
x ./influxdb_0.9.6.1_x86_64/usr/bin/influx
x ./influxdb_0.9.6.1_x86_64/usr/bin/influx_stress
x ./influxdb_0.9.6.1_x86_64/usr/bin/influxd
x ./influxdb_0.9.6.1_x86_64/usr/bin/influx_inspect
x ./influxdb_0.9.6.1_x86_64/usr/lib/
x ./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/
x ./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/
x ./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/influxdb.service
x ./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/init.sh
x ./influxdb_0.9.6.1_x86_64/etc/
x ./influxdb_0.9.6.1_x86_64/etc/influxdb/
x ./influxdb_0.9.6.1_x86_64/etc/influxdb/influxdb.conf
x ./influxdb_0.9.6.1_x86_64/etc/logrotate.d/
x ./influxdb_0.9.6.1_x86_64/etc/logrotate.d/influxdb

But it automatically gets unpacked in the current directory under the folder influxdb_0.9.6.1_x86_64. Are you seeing something different?

@raggi
Copy link
Author

raggi commented Jan 4, 2016

https://gist.github.com/c50cdfa0b968dc65479e will replicate the issue

output:

~ % bash influx-example.sh
working in /tmp/tmp.6fQEWGoqFX
total 8
drwxrwxr-x 2 root  raggi 4096 Jan  4 14:41 .
drwx------ 3 raggi raggi 4096 Jan  4 14:41 ..
./
./influxdb_0.9.6.1_x86_64/
./influxdb_0.9.6.1_x86_64/usr/
./influxdb_0.9.6.1_x86_64/usr/bin/
./influxdb_0.9.6.1_x86_64/usr/bin/influx
./influxdb_0.9.6.1_x86_64/usr/bin/influx_stress
./influxdb_0.9.6.1_x86_64/usr/bin/influxd
./influxdb_0.9.6.1_x86_64/usr/bin/influx_inspect
./influxdb_0.9.6.1_x86_64/usr/lib/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/influxdb.service
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/init.sh
./influxdb_0.9.6.1_x86_64/etc/
./influxdb_0.9.6.1_x86_64/etc/influxdb/
./influxdb_0.9.6.1_x86_64/etc/influxdb/influxdb.conf
./influxdb_0.9.6.1_x86_64/etc/logrotate.d/
./influxdb_0.9.6.1_x86_64/etc/logrotate.d/influxdb
tar: .: Cannot utime: Operation not permitted
tar: .: Cannot change mode to rwx------: Operation not permitted
tar: Exiting with failure status due to previous errors
total 13108
drwxrwxr-x 3 root  raggi     4096 Jan  4 14:41 .
drwx------ 3 raggi raggi     4096 Jan  4 14:41 ..
drwx------ 4 raggi raggi     4096 Dec 10 15:40 influxdb_0.9.6.1_x86_64
-rw-r--r-- 1 raggi raggi 13386496 Jan  4 14:41 influxdb_0.9.6.1_x86_64.tar.gz

The archive contains "./" and it should not. It should only contain the influxdb subdirectory.

The following output further demonstrates the construction and evidence of a correct archive:

/tmp/tmp.6fQEWGoqFX/work % tar ztf influxdb_0.9.6.1_x86_64.tar.gz
./
./influxdb_0.9.6.1_x86_64/
./influxdb_0.9.6.1_x86_64/usr/
./influxdb_0.9.6.1_x86_64/usr/bin/
./influxdb_0.9.6.1_x86_64/usr/bin/influx
./influxdb_0.9.6.1_x86_64/usr/bin/influx_stress
./influxdb_0.9.6.1_x86_64/usr/bin/influxd
./influxdb_0.9.6.1_x86_64/usr/bin/influx_inspect
./influxdb_0.9.6.1_x86_64/usr/lib/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/influxdb.service
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/init.sh
./influxdb_0.9.6.1_x86_64/etc/
./influxdb_0.9.6.1_x86_64/etc/influxdb/
./influxdb_0.9.6.1_x86_64/etc/influxdb/influxdb.conf
./influxdb_0.9.6.1_x86_64/etc/logrotate.d/
./influxdb_0.9.6.1_x86_64/etc/logrotate.d/influxdb
/tmp/tmp.6fQEWGoqFX/work % tar zcf corrected-influxdb_0.9.6.1_x86_64.tar.gz ./influxdb_0.9.6.1_x86_64/
/tmp/tmp.6fQEWGoqFX/work % tar zft corrected-influxdb_0.9.6.1_x86_64.tar.gz
./influxdb_0.9.6.1_x86_64/
./influxdb_0.9.6.1_x86_64/etc/
./influxdb_0.9.6.1_x86_64/etc/influxdb/
./influxdb_0.9.6.1_x86_64/etc/influxdb/influxdb.conf
./influxdb_0.9.6.1_x86_64/etc/logrotate.d/
./influxdb_0.9.6.1_x86_64/etc/logrotate.d/influxdb
./influxdb_0.9.6.1_x86_64/usr/
./influxdb_0.9.6.1_x86_64/usr/lib/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/init.sh
./influxdb_0.9.6.1_x86_64/usr/lib/influxdb/scripts/influxdb.service
./influxdb_0.9.6.1_x86_64/usr/bin/
./influxdb_0.9.6.1_x86_64/usr/bin/influxd
./influxdb_0.9.6.1_x86_64/usr/bin/influx
./influxdb_0.9.6.1_x86_64/usr/bin/influx_stress
./influxdb_0.9.6.1_x86_64/usr/bin/influx_inspect

HTH

@rossmcdonald
Copy link
Contributor

@raggi Understood, thanks for the clarification.

@raggi
Copy link
Author

raggi commented Jan 4, 2016

very welcome, thanks for the patience :)

@rossmcdonald rossmcdonald mentioned this issue Mar 24, 2016
4 tasks
@rossmcdonald
Copy link
Contributor

This has been fixed with #6111, and is now in the latest nightlies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants