-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Server #5994
Single Server #5994
Conversation
benbjohnson
commented
Mar 11, 2016
- CHANGELOG.md updated
- Rebased/mergable
- Tests pass
- Sign CLA (if not already signed)
This commit moves the `tsdb.Store.ExpandSources()` function onto the `influxql.IteratorCreator` and provides support for issuing source expansion across a cluster.
@@ -330,7 +330,7 @@ func (bp *batchpoints) SetRetentionPolicy(rp string) { | |||
|
|||
// Point represents a single data point | |||
type Point struct { | |||
pt models.Point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? pt
was intentionally not exported for v2 client I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was me. I needed this so I could easily create client.Point
from an existing models.Point
. The current NewPoint
function relies on all the separate aspects of a point, which seemed clunky for the way I wanted to use the client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that the v2 client was intended to have points be immutable. Exporting the underlying Point defeats the purpose of that.
What about adding a function like:
NewPointFrom(pt models.Point) {
return &Point{pt:pt}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK will do!
This commit moves the `tsdb.Store.ExpandSources()` function onto the `influxql.IteratorCreator` and provides support for issuing source expansion across a cluster.
07eb551
to
207bafa
Compare
👍 |
2 similar comments
+1 |
👍 |
💥 |