Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Continuous Integration suite for Windows on AppVeyor #6237

Closed
mvadu opened this issue Apr 6, 2016 · 7 comments
Closed

Proposal: Continuous Integration suite for Windows on AppVeyor #6237

mvadu opened this issue Apr 6, 2016 · 7 comments
Milestone

Comments

@mvadu
Copy link
Contributor

mvadu commented Apr 6, 2016

Continuing from #6223, we are getting lot of failure on Windows side (I know its not "officially" supported, but it runs, works on Windows), and we don't have any easy way to know if a PR is going to break compatibility. I am proposing to use AppVeyor's ci, which provides ci for Windows. I have done a POC, https://ci.appveyor.com/project/mvadu/influxdb and we can get the basic things running.

Its not perfect yet, as the current master passes on my local machine (Windows 10, go 1.4.3) but fails on AppVeyor's test. If the team is okay, I will submit a PR for the AppVeyor config, and Influx team (may be @pauldix ) have to register for an account with them.

@toddboom
Copy link
Contributor

toddboom commented Apr 6, 2016

@mvadu This is a great idea. Incidentally, one of the guys on our team spiked on something similar yesterday after the issue you ran into in #6223: mark-rushakoff@20a287f

I think that getting a green build up on AppVeyor is a huge first step for supporting Windows builds, even experimentally. If you want to send in a PR with the AppVeyor config, I'll get it enabled on the repo.

@mvadu
Copy link
Contributor Author

mvadu commented Apr 7, 2016

@toddboom I just pushed #6249 with the config. After spending my whole yesterday to get AppVeyor replace their default go1.6 to 1.4.3, I found an easy one, and the new config is much simpler. One test at the end (tsdb/engine/tsm1) is still failing on that version and passing on my local. Will debug more.

@mvadu
Copy link
Contributor Author

mvadu commented Apr 7, 2016

The failure on AppVeyor was mainly due to dependency management problems, once I sorted out the gdm, Windows ci is running fine. #6249 has been merged to master now. Please get the integration done on AppVeyor.com, and windows tests can be part of each commit to master.

@e-dard
Copy link
Contributor

e-dard commented Apr 14, 2016

Closed via #6249

@e-dard e-dard closed this as completed Apr 14, 2016
@mvadu
Copy link
Contributor Author

mvadu commented Apr 14, 2016

@e-dard could you please share the link to the AppVeyor ci, where you have it integrated? That way I can monitor it, and work on any failures (if I can be of any help to) fix them?

@e-dard
Copy link
Contributor

e-dard commented Apr 14, 2016

Hi @mvadu!

If you look at the details of any open PR you'll now see a link to the AppVeyor build. The main project page is here.

@mvadu
Copy link
Contributor Author

mvadu commented Apr 14, 2016

Awesome!! Thanks much.

@timhallinflux timhallinflux added this to the 0.13.0 milestone Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants