Support join across more than two time series #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The feature is almost complete. But it looks like we don't get the last point. There's a failing test on the branch that needs to be fixed. I'll mark this pr for review when it's ready. |
(from_clause.go,query.yacc,query_types.h): FROM_INNER_JOIN -> FROM_JOIN
| log4go.Fine("JoinEngine: pts = %d", je.pts) | ||
| // if the number of tables ready to emit a point isn't equal to the | ||
| // total number of tables being joined, then return | ||
| if je.pts != len(je.tablesState) { |
There was a problem hiding this comment.
@jvshahid is it possible to end up in a state where a table has no points to emit? Empty table?
There was a problem hiding this comment.
yeah, that could be the case if one of the tables has no points in it. why ?
There was a problem hiding this comment.
Looks like it will return and never actually yield the points if that happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://groups.google.com/forum/#!topic/influxdb/a2hFUFW5PHA