HH Throws error even if disabled

[corylanou]

If you disable (or remove) the HH config, the service won't start and gives this error:

run: HintedHandoff.Dir must be specified. To generate a valid configuration file run `influxd config > influxdb.generated.conf`.

It should not be requiring a directory for a service that is disabled.

[jwilder]

https://github.com/influxdb/influxdb/blob/master/cmd/influxd/run/config.go#L107

[corylanou]

We probably need to change it to:

 else if c.HintedHandoff.Dir == "" && c.HintedHandoff.Enabled

[otoolep]

I took a quick look at this code. I agree there doesn't seem to be a better way.

[otoolep]

Hmm, but the issue is HH is on by default, so it is not as easy as that.

[otoolep]

Anyone familiar with toml processing -- or can just check out the code -- may be able to solve this issue. It's easy to reproduce -- simply pass a config file to influxd that does not contain any HH section.

[ch33hau]

Hi @otoolep , I have created a pull request for this issue, the way to fix is like @corylanou 's comment.
And one more thing is, since the Dir value is mandatory, so I disable HH by default, hope it make sense.

[otoolep]

All done!