-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HH Throws error even if disabled #4283
Comments
We probably need to change it to: else if c.HintedHandoff.Dir == "" && c.HintedHandoff.Enabled |
I took a quick look at this code. I agree there doesn't seem to be a better way. |
Hmm, but the issue is HH is on by default, so it is not as easy as that. |
Anyone familiar with toml processing -- or can just check out the code -- may be able to solve this issue. It's easy to reproduce -- simply pass a config file to |
Hi @otoolep , I have created a pull request for this issue, the way to fix is like @corylanou 's comment. |
…sabled Disable HintedHandoff if configuration is not set. #4283
All done! |
If you disable (or remove) the HH config, the service won't start and gives this error:
It should not be requiring a directory for a service that is disabled.
The text was updated successfully, but these errors were encountered: