Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable window node to window based on count in addition to time. #327

Closed
nathanielc opened this issue Mar 14, 2016 · 3 comments
Closed

Enable window node to window based on count in addition to time. #327

nathanielc opened this issue Mar 14, 2016 · 3 comments
Milestone

Comments

@nathanielc
Copy link
Contributor

Something as simple as:

...
    .window()
        .period(10s)
        .every(10s)
// vs
    .window()
        .period(10)
        .every(10)

Where the first window uses time since durations were passed and the second uses counts since ints were passed.

I like the simplicity, but it might make it easy for a typo to mess up a script in a significant way.

@nathanielc nathanielc changed the title Enable window node to window based on count and not time. Enable window node to window based on count in addition to time. Mar 14, 2016
@yosiat
Copy link
Contributor

yosiat commented Mar 14, 2016

@nathanielc can you explain the reason for this? will it support both?

@nathanielc
Copy link
Contributor Author

Yes, the window node will support both.

@nathanielc
Copy link
Contributor Author

The proposed change is that if you pass ints to the window node it will count points for windowing instead of checking their times.

@nathanielc nathanielc added this to the v0.14 milestone Apr 5, 2016
@nathanielc nathanielc modified the milestones: v0.15, v0.14 Jun 2, 2016
@nathanielc nathanielc modified the milestones: Unplanned, v1.0.0 Aug 24, 2016
@nathanielc nathanielc modified the milestones: v1.2.0, Unplanned Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants