Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlink Subscriptions on shutdown #969

Open
nathanielc opened this issue Oct 13, 2016 · 3 comments
Open

Unlink Subscriptions on shutdown #969

nathanielc opened this issue Oct 13, 2016 · 3 comments
Milestone

Comments

@nathanielc
Copy link
Contributor

Once #928 is fixed, along with that fix will come the ability to unlink subscriptions when they are changed. It seems like a good idea initially to unlinksubscriptions on shutdown so that InfluxDB is not trying to send data to a stopped Kapacitor instance.

This will work well in more dynamic environments, since a clean shutdown Kapacitor instance will not leave any traces behind. In the case that you are just bouncing the Kapacitor service this is extra unneeded work but the overhead has been minimal in practice.

@nathanielc nathanielc added this to the v1.1.0 milestone Oct 13, 2016
@nathanielc
Copy link
Contributor Author

nathanielc commented Oct 19, 2016

This will cause data loss when the subscriptions are not present, it would be better to make it easier to clean up after subscriptions via a DROP ALL SUBSCRIPTIONS WITH NAME "aaaa" or similar query.

@mnp
Copy link

mnp commented Mar 10, 2017

This seems to work: drop subscription "kapacitor-949368b5-34dd-44ac-aeec-65b4a7abec50" on "telegraf"."autogen" but it raises another question. If you do a show subscriptions, it looks like a subscription is on every database with retention autogen as well as on _internal as monitor. Which ones do you want to nuke?

@docmerlin
Copy link
Contributor

Is this still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants