🐛 Fix p command for umbrella projects
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an umbrella project, the `p` (pattern) command was not matching any files. This happened because it uses `test` as the default path to find files to match, which doesn't exist in an umbrella project. With this change, we detect an umbrella project and in that case, wildcard-match the `test` directories of all of the apps in the umbrella. It is still possible to specify the `:test_paths` config option for `mix test`. If that config setting is present, `mix test.interactive` will use that setting and not default to the wildcard setting.
hansenreid
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an umbrella project, the
p(pattern) command was not matching any files.This happened because it uses
testas the default path to find files to match, which doesn't exist in an umbrella project.With this change, we detect an umbrella project and in that case, wildcard-match the
testdirectories of all of the apps in the umbrella.It is still possible to specify the
:test_pathsconfig option formix test. If that config setting is present,mix test.interactivewill use that setting and not default to the wildcard setting.