Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: CI builds artifacts for a pull request after merging them into master locally #9977

Closed
sspaink opened this issue Oct 22, 2021 · 1 comment · Fixed by #10993
Closed
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@sspaink
Copy link
Contributor

sspaink commented Oct 22, 2021

I would like to propose that when the CI builds artifacts for a pull request, that it first attempts to merge the changes into master, and then those artifacts will be shared to the user.

  • On merge failure: the CI will fail and stop, we can't merge the changes anyway when there is a conflict. This should help prevent unnecessary CI builds when the author will have to rebase anyway.
  • On successful merge: the artifacts will be built based on this new master branch, the benefits will be that when you test your PR it will be as if it was merged. This will also help the tiger bot give better results when telling you the binary file size change in case the forked repo the pr is based on is behind master.

Alternatively, we could be more flexible and have the CI continue even if the PR can't be merged into master yet and have the bot add a message telling them to resolve the merge conflict. At the moment I prefer the fail if there is a conflict approach, but open for discussion.

@sspaink sspaink added the feature request Requests for new plugin and for new features to existing plugins label Oct 22, 2021
@srebhan
Copy link
Member

srebhan commented Oct 22, 2021

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants