Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize CLI command for query connection/channel end #393

Open
soareschen opened this issue Jul 25, 2024 · 2 comments
Open

Generalize CLI command for query connection/channel end #393

soareschen opened this issue Jul 25, 2024 · 2 comments
Labels

Comments

@soareschen
Copy link
Collaborator

Part of #392.

Summary

This task focuses on generalizing the CLI code for querying the connection end and channel end. The generalized components can be placed in the hermes-cli-components crate.

You can check related PRs such as #391 on how this can be done.

Things to note

  • The original CLI checks for whether the state is uninitialized, and return error if so. This is not needed for the generalized CLI, as the ConnectionEnd type is generic. This would already been handled by the Cosmos-specific implementation of CanQueryConnectionEnd.
  • We don't need to use AnyCounterparty in the query, as the type of the connection end depends on the target chain.
@soareschen soareschen added the cli label Jul 25, 2024
@soareschen soareschen assigned soareschen and unassigned soareschen Jul 25, 2024
@soareschen
Copy link
Collaborator Author

@thaodt you can work on this issue.

@thaodt
Copy link

thaodt commented Jul 26, 2024

@thaodt you can work on this issue.

thanks Soares, I'm gonna finish the last Querier PR and take this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants