Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a keys delete command to remove keys from Hermes configuration #1065

Closed
3 of 5 tasks
andynog opened this issue Jun 8, 2021 · 1 comment · Fixed by #1174
Closed
3 of 5 tasks

Add a keys delete command to remove keys from Hermes configuration #1065

andynog opened this issue Jun 8, 2021 · 1 comment · Fixed by #1174
Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@andynog
Copy link
Contributor

andynog commented Jun 8, 2021

Crate

Hermes should provide a command to remove keys from its configuration. This might help with key maintenance and also to remove incompatible keys.

Summary

As a user/operator I want to have a command to remove a previously added keys for a chain removed from Hermes keys store (`~/.hermes/keys)

Problem Definition

Currently we only support updating keys adding or restoring them again. But there might be cases where a key needs to be removed (e.g. incompatible key)

Proposal

We should implement a command e.g. keys delete [chain-id] -n [key-name]

We could also implement a keys delete --all to clean the whole key store if it makes sense.

Acceptance Criteria

Keys are removed using the Hermes command


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@andynog andynog added O: new-feature Objective: cause to add a new feature or support I: CLI Internal: related to the relayer's CLI labels Jun 8, 2021
@andynog andynog added this to the 06.2021 milestone Jun 8, 2021
@adizere adizere modified the milestones: 06.2021, 08.2021 Jun 22, 2021
@hu55a1n1
Copy link
Member

Should we name the command delete instead of clean? Just to stay consistent with gaiad?

@hu55a1n1 hu55a1n1 mentioned this issue Jul 12, 2021
5 tasks
@romac romac changed the title Add a keys clean command to remove keys from Hermes configuration Add a keys delete command to remove keys from Hermes configuration Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants