Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uint256 transfer amount #1319

Closed
5 tasks done
Tracked by #1330
colin-axner opened this issue Aug 31, 2021 · 0 comments · Fixed by #1329
Closed
5 tasks done
Tracked by #1330

Support uint256 transfer amount #1319

colin-axner opened this issue Aug 31, 2021 · 0 comments · Fixed by #1329
Assignees
Labels
I: dependencies Internal: related to dependencies I: logic Internal: related to the relaying logic
Milestone

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Aug 31, 2021

Crate

relayer-cli, v0.7.0

Summary

When attempting to transfer an amount of 2^64, an error is returned. I am testing a change in ibc-go which increases the allowed transfer amount from uint64 to uint256

Problem Definition

hermes  tx raw ft-transfer network1 network2 transfer channel-0 18446744073709551616 -d samoleans -t 180
error: invalid argument to option `amount`: number too large to fit in target type

Do the proto files need to be regenerated?

Proposal

Support up to uint256 transfer amounts

Acceptance Criteria

ft-transfer works with uint256 amounts


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added I: dependencies Internal: related to dependencies I: logic Internal: related to the relaying logic labels Sep 6, 2021
@adizere adizere added this to the 09.2021 milestone Sep 6, 2021
@adizere adizere mentioned this issue Sep 7, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies I: logic Internal: related to the relaying logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants