Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FromStr<Path> for ics24_host::Path #1460

Closed
2 of 5 tasks
seanchen1991 opened this issue Oct 15, 2021 · 0 comments · Fixed by #1480 or #1499
Closed
2 of 5 tasks

Implement FromStr<Path> for ics24_host::Path #1460

seanchen1991 opened this issue Oct 15, 2021 · 0 comments · Fixed by #1480 or #1499
Assignees
Labels
O: new-feature Objective: cause to add a new feature or support

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Oct 15, 2021

Crate

The ibc crate.

Summary

Implement FromStr<Path> for ics24_host::Path in order to facilitate deserialization in concrete Paths in basecoin-rs.

Problem Definition

As part of #14 in basecoin-rs, we're looking to add the ability to deserialize string paths into concrete Paths. While this could be done on the Basecoin side, this is functionality that others will likely find useful so well, so it makes sense to implement it in ibc-rs to reduce code duplication.

Proposal

Implement FromStr<Path>, which would essentially be doing the opposite of the Display<Path> impl.

Acceptance Criteria

Implementing of FromStr<Path> added with adequate testing coverage.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@seanchen1991 seanchen1991 added the O: new-feature Objective: cause to add a new feature or support label Oct 15, 2021
@seanchen1991 seanchen1991 self-assigned this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant