Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching away from rouille #1658

Closed
1 of 5 tasks
mzabaluev opened this issue Dec 8, 2021 · 1 comment · Fixed by #3200
Closed
1 of 5 tasks

Consider switching away from rouille #1658

mzabaluev opened this issue Dec 8, 2021 · 1 comment · Fixed by #3200
Assignees
Labels
I: dependencies Internal: related to dependencies I: telemetry Internal: related to Telemetry & metrics O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@mzabaluev
Copy link
Contributor

mzabaluev commented Dec 8, 2021

Crate

ibc-relayer-rest, ibc-telemetry

Summary

The rouille crate imposes an unnecessary restriction on its time dependency, holding back useful changes.

Problem Definition

The crates depend on rouille, which pins its dependency on time to =0.3.2: tomaka/rouille#246

This will come into conflict with changes made in informalsystems/tendermint-rs#1030 and has already caused a rollback in informalsystems/tendermint-rs#1047.

Proposal

Switch to axum, or any other suitable web service framework without dependency issues.

Acceptance Criteria

The problem is resolved upstream, or this project removes the rouille dependency.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@mzabaluev mzabaluev added O: new-feature Objective: cause to add a new feature or support I: dependencies Internal: related to dependencies I: telemetry Internal: related to Telemetry & metrics labels Dec 8, 2021
@mzabaluev
Copy link
Contributor Author

mzabaluev commented Dec 13, 2021

Once #1665 is in, rouille will be the last obstacle to fixing #1478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies I: telemetry Internal: related to Telemetry & metrics O: new-feature Objective: cause to add a new feature or support
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants