Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WARN logging level for missing chain id in configuration file #1936

Closed
5 tasks
karzak opened this issue Mar 5, 2022 · 2 comments · Fixed by #2089
Closed
5 tasks

Remove WARN logging level for missing chain id in configuration file #1936

karzak opened this issue Mar 5, 2022 · 2 comments · Fixed by #2089
Assignees
Labels
I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@karzak
Copy link

karzak commented Mar 5, 2022

Crate

relayer

Summary

When running hermes, I don't see why missing chain for id ({}) in configuration file should be log_level = WARN.

Problem Definition

In practice, relayers know which chains they are trying to relay between, and this message becomes very noisy/redundant. If you are relaying between chains with lower traffic, 90% of logs are just that warning, making it difficult to parse when actual errors/warnings occur.

Proposal

I wouldn't log anything for this event because things happening on chains that are not in config.toml are irrelevant to the relayer operator. I could also see making it log_level = DEBUG.

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere moved this to Backlog in IBC-rs: the road to v1 Mar 7, 2022
@adizere adizere added this to the v0.13.0 milestone Mar 7, 2022
@adizere adizere added I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Mar 7, 2022
@faddat
Copy link
Contributor

faddat commented Mar 10, 2022

Hi guys, I wish I had thought of the simple solution myself. This will definitely make logs easier to read.

@romac romac self-assigned this Mar 21, 2022
@adizere adizere modified the milestones: v0.13.0, v0.14.0 Mar 24, 2022
@adizere adizere moved this from Backlog to Needs PR in IBC-rs: the road to v1 Mar 31, 2022
@hu55a1n1 hu55a1n1 moved this from Needs PR to Needs Review in IBC-rs: the road to v1 Apr 19, 2022
Repository owner moved this from Needs Review to Closed in IBC-rs: the road to v1 Apr 21, 2022
@adizere
Copy link
Member

adizere commented Apr 21, 2022

@karzak and @faddat: We added a fix to the problem, it is currently in master. Feel free to test and we would appreciate any feedback, thanks!

We plan to release the fix next week as part of v0.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
4 participants