Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade simapp files to run with latest simd #204

Closed
andynog opened this issue Aug 13, 2020 · 3 comments
Closed

Upgrade simapp files to run with latest simd #204

andynog opened this issue Aug 13, 2020 · 3 comments
Assignees
Labels
I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@andynog
Copy link
Contributor

andynog commented Aug 13, 2020

Change simapp configuration to include more than one connection. This will allow properly testing of queries such as connections per client.

@andynog andynog added the O: new-feature Objective: cause to add a new feature or support label Aug 13, 2020
@ancazamfir ancazamfir added this to the v.0.0.3 milestone Aug 14, 2020
@ancazamfir ancazamfir added the I: logic Internal: related to the relaying logic label Aug 14, 2020
@andynog
Copy link
Contributor Author

andynog commented Aug 21, 2020

We might need to update the simapp to the latest version in order to have this properly configured. Looks like our current simapp doesn't do client_id validation for a particular connection

@ancazamfir ancazamfir modified the milestones: v.0.0.3, v0.0.4 Aug 25, 2020
@ebuchman ebuchman modified the milestones: v0.0.4, v0.0.5 Aug 28, 2020
@andynog andynog changed the title Configure simapp to have two connections Upgrade simapp files to run with latest simd Oct 7, 2020
@andynog
Copy link
Contributor Author

andynog commented Oct 7, 2020

Tried to run simd --home ./simapp/ start using a compiled simd built from the latest cosmos-sdk (master) and it spits out an error. I believe it has to do with the proto changes. Our simapp files were generated before protobuf changes on cosmos-sdk. We need to regenerated the simapp folder using the latest simd.

simd --home ./simapp/ start
I[2020-10-07|17:30:57.973] starting ABCI with Tendermint                module=main 
panic: Any JSON doesn't have '@type'

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/codec.(*ProtoCodec).MustUnmarshalJSON(0xc001044330, 0xc000f44480, 0x10e, 0x120, 0x1eaabe0, 0xc000699d00)
	github.com/cosmos/cosmos-sdk/codec/proto_codec.go:150 +0x8a
github.com/cosmos/cosmos-sdk/x/auth.AppModule.InitGenesis(0x1ea01e0, 0xc0006b2ef0, 0x1ecfa20, 0xc001044330, 0x1ecfa20, 0xc001044330, 0xc000010178, 0x1ea01e0, 0xc0006b2f90, 0x1ea0260, ...)
	github.com/cosmos/cosmos-sdk/x/auth/module.go:139 +0xa4
github.com/cosmos/cosmos-sdk/types/module.(*Manager).InitGenesis(0xc000f3abd0, 0x1ebe4a0, 0xc000124030, 0x1ed30e0, 0xc000699bc0, 0x0, 0x0, 0xc00126a240, 0x8, 0x0, ...)
	github.com/cosmos/cosmos-sdk/types/module/module.go:306 +0x2b5
github.com/cosmos/cosmos-sdk/simapp.(*SimApp).InitChainer(0xc0000fc000, 0x1ebe4a0, 0xc000124030, 0x1ed30e0, 0xc000699bc0, 0x0, 0x0, 0xc00126a240, 0x8, 0x0, ...)
	github.com/cosmos/cosmos-sdk/simapp/app.go:454 +0x170
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).InitChain(0xc000602d80, 0x18188888, 0xed69708b8, 0x0, 0xc00126a240, 0x8, 0xc000f3f0a0, 0x2a15830, 0x0, 0x0, ...)

@ancazamfir ancazamfir modified the milestones: v0.0.5, v0.0.7 Oct 16, 2020
@adizere adizere mentioned this issue Nov 9, 2020
42 tasks
@andynog andynog self-assigned this Nov 10, 2020
@ancazamfir ancazamfir modified the milestones: v0.0.7, v0.0.8 Dec 23, 2020
@adizere adizere mentioned this issue Jan 20, 2021
5 tasks
@adizere
Copy link
Member

adizere commented Jan 22, 2021

Superseded by #32 and the line of work for CI/end-to-end testing.

@adizere adizere closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

No branches or pull requests

4 participants