Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Ugrade Command Not Working in v0.14.1 #2185

Closed
5 tasks
rhuairahrighairidh opened this issue May 5, 2022 · 2 comments · Fixed by #2304
Closed
5 tasks

Client Ugrade Command Not Working in v0.14.1 #2185

rhuairahrighairidh opened this issue May 5, 2022 · 2 comments · Fixed by #2304
Labels
A: bug Admin: something isn't working O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@rhuairahrighairidh
Copy link

rhuairahrighairidh commented May 5, 2022

Summary of Bug

The command hermes tx raw upgrade-client is failing in v0.14.1, but working in v0.14.0.

I believe it's due to this issue: #2021

The command tries to fetch the upgraded consensus state from the last block of the old chain but fails to find it, because it uses the wrong block height.

Previously it used the last block as reported by /status rpc, but now uses another method. When the chain halts, the two methods differ: /status returns the uncommited halted height (listed in the upgrade plan), the other returns the last commited height (one before the upgrade plan).

Note, although technically the last commited consensus state is for one block before the upgrade height, the cosmo-sdk upgrade querier stores it under the upgrade height.

Version

v0.14.1

Steps to Reproduce

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@rhuairahrighairidh rhuairahrighairidh changed the title Client Ugrade Command Broken in v0.14.1 Client Ugrade Command Not Working in v0.14.1 May 5, 2022
@adizere
Copy link
Member

adizere commented May 9, 2022

Hmm, this is an interesting corner-case. Thanks for bringing it to our attention!

@adizere adizere added this to the v1.0.0 milestone May 9, 2022
@adizere adizere added the A: bug Admin: something isn't working label May 9, 2022
@V-Staykov
Copy link

Ah thank you! We were debugging the same problem.

@adizere adizere added O: usability Objective: cause to improve the user experience (UX) and ease using the product P-medium labels May 27, 2022
@plafer plafer mentioned this issue Jun 15, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants