Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit tests for Hermes commands parsing #2358

Closed
5 tasks
ljoss17 opened this issue Jun 30, 2022 · 0 comments · Fixed by #2352
Closed
5 tasks

Adding unit tests for Hermes commands parsing #2358

ljoss17 opened this issue Jun 30, 2022 · 0 comments · Fixed by #2352

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jun 30, 2022

Summary

Adding unit testing for parsing Hermes commands.

Problem Definition

Adding unit tests for the command parsing following the ADR 010 will decrease the risks of having the commands not synched with the ADR.

Proposal

Adding unit tests for all the commands in order to cover as many use cases.

Acceptance Criteria

  • Unit tests for all commands with at least one argument.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLI unit-testing for all commands with at least one argument informalsystems/hermes
1 participant
@ljoss17