-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the type_url explicit strings into constants #254
Labels
A: good-first-issue
Admin: good for newcomers
O: code-hygiene
Objective: cause to improve code hygiene
Milestone
Comments
6 tasks
5 tasks
We should use the fn Currently this is only implemented for a handful of type, e.g., MsgCreateAnyClient: |
This has been taken care over a number of PRs (see git blame :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: good-first-issue
Admin: good for newcomers
O: code-hygiene
Objective: cause to improve code hygiene
Summary
With the migration to the new protobufs we need to keep track of the
type_url
used byprost_types::Any
.Currently these are used in clear, e.g.:
https://github.com/informalsystems/ibc-rs/blob/3e60e67b679ffab65b1a173b1af12411eb08d4c5/modules/src/ics02_client/client_def.rs#L128-L130
For Admin Use
The text was updated successfully, but these errors were encountered: