Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the type_url explicit strings into constants #254

Closed
4 tasks
ancazamfir opened this issue Sep 24, 2020 · 2 comments
Closed
4 tasks

Extract the type_url explicit strings into constants #254

ancazamfir opened this issue Sep 24, 2020 · 2 comments
Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: cause to improve code hygiene
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Summary

With the migration to the new protobufs we need to keep track of the type_url used by prost_types::Any.
Currently these are used in clear, e.g.:
https://github.com/informalsystems/ibc-rs/blob/3e60e67b679ffab65b1a173b1af12411eb08d4c5/modules/src/ics02_client/client_def.rs#L128-L130


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added the O: code-hygiene Objective: cause to improve code hygiene label Sep 24, 2020
@ancazamfir ancazamfir added this to the v0.0.5 milestone Sep 24, 2020
@adizere adizere added the A: good-first-issue Admin: good for newcomers label Sep 24, 2020
@adizere
Copy link
Member

adizere commented Nov 6, 2020

This was referenced Nov 6, 2020
@adizere adizere modified the milestones: v0.0.5, v0.0.6 Dec 2, 2020
@adizere adizere modified the milestones: v0.0.6, v0.0.7 Dec 23, 2020
@ancazamfir
Copy link
Collaborator Author

This has been taken care over a number of PRs (see git blame :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: cause to improve code hygiene
Projects
None yet
Development

No branches or pull requests

2 participants