Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes sometimes fails to retrieve the begin/end block events #2867

Closed
5 tasks
ancazamfir opened this issue Nov 16, 2022 · 0 comments · Fixed by #2870
Closed
5 tasks

Hermes sometimes fails to retrieve the begin/end block events #2867

ancazamfir opened this issue Nov 16, 2022 · 0 comments · Fixed by #2870
Assignees
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Nov 16, 2022

Summary of Bug

cc @romac
We discovered an issue with block_search RPC on the incentivized ICS testnet. The query results are not what we expect from hermes for begin/ end block events.
The tendermint issue to clarify this is tendermint/tendermint#9712.
While we are waiting for a resolution on this we will likely need to have a fix in hermes.

When querying for the begin/ end block events for a given event and packet, block_search may return a list of blocks. We need to retrieve the block_results for each block and find the one that includes the one event with the type and attributes matching the query. Currently we only ask for one block in block_search and we attempt to retrieve the results for that one block which may not be the correct one, resulting in packet data not being found and relaying failing.

Version

all

Steps to Reproduce

Currently this is not easy without a custom gaia or using the ICS testnet.
We should write integration tests if possible.

Acceptance Criteria

Be able to retrieve the block and results that include the event with the exact attributes in query.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants