Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CometBFT version in health-check #3288

Closed
5 tasks
ljoss17 opened this issue May 1, 2023 · 0 comments · Fixed by #3286
Closed
5 tasks

Add support for CometBFT version in health-check #3288

ljoss17 opened this issue May 1, 2023 · 0 comments · Fixed by #3286

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented May 1, 2023

Summary

Currently the health-check verifies the Tendermint version.
When a chains with the SDK version v0.46.11+ is queried to obtain the version information, it will give a CometBFT version instead of a Tendermint version. This will cause an error output since no Tendermint version will be found.

Hermes needs to be updated to check for Tendermint or CometBFT version.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes May 1, 2023
@johnletey johnletey mentioned this issue May 1, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support CometBFT dependency KYVENetwork/hermes
1 participant
@ljoss17