Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of packet acknowledgement queries #3348

Closed
1 of 7 tasks
seanchen1991 opened this issue May 17, 2023 · 0 comments · Fixed by #3347
Closed
1 of 7 tasks

Reduce the size of packet acknowledgement queries #3348

seanchen1991 opened this issue May 17, 2023 · 0 comments · Fixed by #3347
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented May 17, 2023

Summary

#3334 uncovered an issue where query_packet_acknowledgements returns too much data such that it surpasses the 4MB message decoding limit imposed by the dependency on tonic.

#3335 addressed this by increasing the message decoding limit (and also making it configurable). However, this doesn't address the root cause of the issue, which is that this query shouldn't return this much data in the first place.

The query_packet_acknowledgements query asks the chain to fetch acknowledgements for all sequences in the packet_commitment_sequences list. However, if this list is empty when the query is made, i.e., there is nothing to be relayed, the query returns all packet acknowledgements for the given channel, hence why the query sometimes returns too much data.

Acceptance Criteria

To address the root cause of this issue, the query_packet_acknowledgements query should not return any acknowledgements when the packet_commitment_sequences list is empty. We should also be able to revert the message decoding limit to 4MB, though we should perhaps keep this value configurable.

  • Change query_packet_acknowledgements query should not return any acknowledgements when the packet_commitment_sequences list is empty
  • Revert the message decoding limit back to 4MB

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes May 17, 2023
@seanchen1991 seanchen1991 added the A: bug Admin: something isn't working label May 17, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 👀 In review in Hermes May 17, 2023
@seanchen1991 seanchen1991 moved this from 👀 In review to 🏗 In progress in Hermes May 17, 2023
@seanchen1991 seanchen1991 added this to the v1.5 milestone May 17, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: ✅ Done
2 participants