Metric broadcast_errors is not correctly batching the same errors together

[ljoss17]

Summary of Bug

The metric broadcast_errors introduced in Hermes v1.7.2 uses the error code and error description as label. The issue is that some error description have variables in them causing Hermes to consider them as different errors, for example it would record two separate metrics for due to the required fee being different:

broadcast_errors_total{account="<account_1>",error_code="13",error_description="insufficient fees; got: 1234stake which converts to 1234stake. required: 2345stake: insufficient fee"} 1
broadcast_errors_total{account="<account_1>",error_code="13",error_description="insufficient fees; got: 1234stake which converts to 1234stake. required: 3456stake: insufficient fee"} 1

Version

Hermes v1.7.3

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned