Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hermes missing some interchainquery events #3954

Closed
5 tasks
ljoss17 opened this issue Apr 18, 2024 · 0 comments · Fixed by #3944
Closed
5 tasks

Hermes missing some interchainquery events #3954

ljoss17 opened this issue Apr 18, 2024 · 0 comments · Fixed by #3944
Assignees
@ljoss17
Labels
A: critical Admin: critical or important O: ics31-cross-chain-queries Objective: ICS 031, Cross-Chain Queries

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Apr 18, 2024 •
edited by romac
Loading

Summary of Bug

Hermes will not pick-up all interchainquery RPC events if there more than one emitted at the same time. It will only retrieve the first one:

hermes/crates/relayer-types/src/applications/ics31_icq/events.rs

Line 97 in 4ece16a

fn fetch_first_element_from_events(

Version

Latest commit 4ece16adb56b4b8f3a6c331f6ca6a3551a12265a

Acceptance Criteria

All interchainquery events should be picked-up and relayed.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added O: ics31-cross-chain-queries Objective: ICS 031, Cross-Chain Queries A: critical Admin: critical or important labels Apr 18, 2024
@ljoss17 ljoss17 self-assigned this Apr 18, 2024
@ljoss17 ljoss17 mentioned this issue Apr 18, 2024
Merged
7 tasks
@romac romac mentioned this issue Apr 18, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljoss17 ljoss17

Labels
A: critical Admin: critical or important O: ics31-cross-chain-queries Objective: ICS 031, Cross-Chain Queries
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Gaia, Stride, Neutron and Osmosis versions used in CI informalsystems/hermes
1 participant
@ljoss17