Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ADR to unify Hermes CLI options for v1 #594

Closed
2 of 8 tasks
ancazamfir opened this issue Feb 1, 2021 · 2 comments · Fixed by #2306
Closed
2 of 8 tasks

Introduce ADR to unify Hermes CLI options for v1 #594

ancazamfir opened this issue Feb 1, 2021 · 2 comments · Fixed by #2306
Labels
I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone
v1.0.0

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Feb 1, 2021 •
edited by adizere
Loading

Crate

realyer-cli

Summary of Bug

Some of the relayer CLIs have redundant (e.g. connection and channel IDs are not used in open-init CLIs) or unneeded parameters (e.g. for open-ack and open-confirm the client IDs can be obtained by querying the connections).
All CLIs should be reviewed.

Version

Steps to Reproduce

  • Exercise the relayer CLIs
  • Consider removing all positional arguments and use only named arguments in CLIs -> separate issue
  • Propose an ADR to unify how we specify options and flags to CLIs

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the v0.1.2 milestone Feb 1, 2021
@ancazamfir ancazamfir mentioned this issue Feb 1, 2021
Merged
20 tasks
@romac
Copy link
Member

romac commented Feb 1, 2021

See 9c98b89 for tx raw commands for connections.

@romac
Copy link
Member

romac commented Feb 1, 2021

Done for tx raw chan-open-* commands as well

@adizere adizere mentioned this issue Mar 18, 2021
Closed
@romac romac added I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Nov 17, 2021
@adizere adizere modified the milestones: Backlog, v1.0.0 Dec 25, 2021
@adizere adizere modified the milestones: v1.0.0, v0.13.0 Feb 22, 2022
@adizere adizere modified the milestones: v0.15.0, v1.0.0 Apr 26, 2022
This was referenced May 3, 2022
Merged
Open
@adizere adizere added the P-high label May 24, 2022
@adizere adizere changed the title Cleanup relayer CLIs Introduce ADR to unify Hermes CLI options for v1 Jun 17, 2022
@adizere adizere linked a pull request Jun 17, 2022 that will close this issue
ADR for unified approach for CLI arguments for Hermes #2306
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
IBC-rs: the road to v1
Status: Closed
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

ADR for unified approach for CLI arguments for Hermes informalsystems/hermes
3 participants
@romac @adizere @ancazamfir