Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up light client related code #90

Closed
milosevic opened this issue Jun 9, 2020 · 2 comments · Fixed by #255
Closed

Clean up light client related code #90

milosevic opened this issue Jun 9, 2020 · 2 comments · Fixed by #255
Assignees
@romac @milosevic
Labels
A: help-wanted Admin: extra attention is needed, good for seniors I: logic Internal: related to the relaying logic
Milestone
v0.0.4

Comments

@milosevic
Copy link
Contributor

milosevic commented Jun 9, 2020 •
edited by ebuchman
Loading

Review the relayers use of the light-client and tendermint and clean up any lose ends. Minimize the code the relayer needs to setup and manage the light-client by adding more functionality to the light-client crate and to ics07 module as necessary. Any light-client specific logic should be handled in the light-client Eg. light-client needs to properly handle initialization (informalsystems/tendermint-rs#484).
@ancazamfir ancazamfir added this to the 0.7-7mo milestone Jun 15, 2020
@milosevic milosevic assigned milosevic and unassigned Shivani912 Jun 18, 2020
@ancazamfir ancazamfir mentioned this issue Jun 29, 2020
Closed
@ebuchman ebuchman modified the milestones: v.0.0.3, v0.0.2 Jul 7, 2020
@adizere adizere added A: help-wanted Admin: extra attention is needed, good for seniors I: logic Internal: related to the relaying logic relayer_client labels Jul 21, 2020
@ebuchman ebuchman mentioned this issue Jul 30, 2020
Closed
@ebuchman
Copy link
Member

Some cleanup can probably already be done but this also blocks on informalsystems/tendermint-rs#484

@ebuchman ebuchman modified the milestones: v0.0.2, v.0.0.3 Jul 30, 2020
@ebuchman ebuchman mentioned this issue Jul 30, 2020
Closed
4 tasks
@romac romac self-assigned this Aug 3, 2020
@ancazamfir ancazamfir modified the milestones: v.0.0.3, v0.0.4 Aug 14, 2020
@ebuchman ebuchman mentioned this issue Sep 11, 2020
Closed
@ebuchman
Copy link
Member

Related to #243 - need to update to tendermint-rs v0.16 and replace all use of the now removed lite module

This was referenced Sep 22, 2020
Closed
Closed
@ancazamfir ancazamfir mentioned this issue Sep 23, 2020
Merged
6 tasks
@romac romac mentioned this issue Sep 25, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

@milosevic milosevic

Labels
A: help-wanted Admin: extra attention is needed, good for seniors I: logic Internal: related to the relaying logic
Projects
None yet
Milestone
v0.0.4
Development

Successfully merging a pull request may close this issue.

Update to latest tendermint-rs and adapt relayer to new light client informalsystems/hermes
6 participants
@romac @milosevic @adizere @ebuchman @ancazamfir @Shivani912