Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event parsing message.action preparation for new SDK version #918

Closed
5 tasks
colin-axner opened this issue May 7, 2021 · 2 comments · Fixed by #948
Closed
5 tasks

Event parsing message.action preparation for new SDK version #918

colin-axner opened this issue May 7, 2021 · 2 comments · Fixed by #948
Labels
I: rpc Internal: related to (g)RPC O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@colin-axner
Copy link
Contributor

Crate

relayer

Summary

In the next release of the SDK, message.action will emit a different value than previous versions.

Problem Definition

Hermes should be capable of consuming the old message.action and consuming the new message.action

Proposal

I believe this code needs to be modified to accept:
create_client OR /ibc.core.client.v1.MsgCreateClient

Please see relevant discussion for more information


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added O: new-feature Objective: cause to add a new feature or support I: rpc Internal: related to (g)RPC labels May 12, 2021
@colin-axner
Copy link
Contributor Author

Confirmed this will be an issue for the next version of ibc-go:

May 14 16:55:15.183  WARN ibc_relayer::event::rpc: error while building event Incorrect event type: '/ibc.applications.transfer.v1.MsgTransfer'

@ancazamfir
Copy link
Collaborator

ancazamfir commented May 14, 2021

Confirmed this will be an issue for the next version of ibc-go:

May 14 16:55:15.183  WARN ibc_relayer::event::rpc: error while building event Incorrect event type: '/ibc.applications.transfer.v1.MsgTransfer'

How did you test this? With gaia from latest hub/cosmoshub-4.6?

Fixed in #948

  • tested with gaia: hub/cosmoshub-4.6
  • also works with gaia v4.2.1
  • still need to test mixed chain versions.

Opened #947 - a high level issue for the migration/ upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: rpc Internal: related to (g)RPC O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants