Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular logic for ICS3 Connection handshake protocol #92

Closed
milosevic opened this issue Jun 10, 2020 · 3 comments
Closed

Modular logic for ICS3 Connection handshake protocol #92

milosevic opened this issue Jun 10, 2020 · 3 comments
Labels
I: logic Internal: related to the relaying logic
Milestone

Comments

@milosevic
Copy link
Contributor

milosevic commented Jun 10, 2020

Before relayer forward IBC message to the destination, it is supposed to do checks (commitment proofs checks, business logic checks) equivalent to the checks done on chain by the corresponding ICS message handler.

The idea is to implement these checks, directly in the ibc crate, in a modular manner so that both the IBC modul and the relayer create can use them. As part of this larger task we need to implement the various verification method similar as defined in ClientState: https://github.com/cosmos/cosmos-sdk/blob/55796fb3e73c222eb97c1308d4eee26144e8189f/x/ibc/02-client/exported/exported.go#L17.

@ancazamfir ancazamfir added this to the 0.8-8mo milestone Jun 15, 2020
@ebuchman ebuchman changed the title Implement message validation logic for Connection handshake messages Relayer message validation logic for Connection handshake messages Jul 30, 2020
@ebuchman ebuchman modified the milestones: v0.0.4, v0.0.5 Aug 28, 2020
@ancazamfir ancazamfir modified the milestones: v0.0.5, v0.0.7 Oct 16, 2020
@adizere adizere added the I: logic Internal: related to the relaying logic label Nov 6, 2020
@adizere adizere changed the title Relayer message validation logic for Connection handshake messages Modular message validation logic for ICS3 Connection handshake messages Nov 6, 2020
@adizere
Copy link
Member

adizere commented Nov 6, 2020

Given the addition of domain types (which handle message validation), it's unclear if this issue is still relevant. There is some potential to reuse business logic of processing certain messages, however. So we can investigate this in the context of ICS3 specifically, while implementing #377. The goal would be that relayer-side logic would import and reuse verification functions (not only for clients & proofs).

@adizere adizere changed the title Modular message validation logic for ICS3 Connection handshake messages Modular logic for ICS3 Connection handshake protocol Nov 6, 2020
This was referenced Nov 9, 2020
@adizere
Copy link
Member

adizere commented Nov 10, 2020

Cf: #388 (comment)

@adizere
Copy link
Member

adizere commented Sep 30, 2022

Closing as stale.

@adizere adizere closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: logic Internal: related to the relaying logic
Projects
None yet
Development

No branches or pull requests

4 participants