-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning is not fully consistent with ICS-es #97
Labels
A: help-wanted
Admin: extra attention is needed, good for seniors
Milestone
Comments
Shivani912
added
A: help-wanted
Admin: extra attention is needed, good for seniors
TODO
labels
Jun 10, 2020
Which ADR-03 and ADR-04 are we talking about exactly? (They're not in this repo, right?) |
ancazamfir
changed the title
Versioning is not fully consistent with ADR
Versioning is not fully consistent with ICS-es
Jun 11, 2020
For now let's leave it like it as is in SDK code and your PR. I will move this to a later milestone (the relayer delivery one) |
My bad @adizere I was talking about the ICSes 03 and 04 |
Final fixes with #388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
""
if needed.Version
string and require some validation onversion
->String
andversions
->Vec<String>
. For now, this is handled by two functions which are part of Connection module in code and this is simply to get the work done fast but this needs to be discussed on how we want to do it moving forward.Proposed Solution
The text was updated successfully, but these errors were encountered: