-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About the use of WriteAcknowledgement #36
Comments
Nice catch @DaviRain-Su! ibc-rs indeed does not handle the synchronous case for |
Related issue/bug -> #35. |
Based on your feedback I made an attempt to modify |
* add write_acknowledgement process on packet_callback * fix bug * extract write_ack logic to process_write_ack function * add issue #2424 and 2438 to changelog * Derive From/Into for opaque Ack * Use generic Ack as writeAck input * Simplify Ack trait * Process write ack using conversion to generic Ack * Allow `packet_callback()` to emit IbcEvents Co-authored-by: hu55a1n1 <sufialhussaini@gmail.com>
…2439) * add write_acknowledgement process on packet_callback * fix bug * extract write_ack logic to process_write_ack function * add issue #2424 and 2438 to changelog * Derive From/Into for opaque Ack * Use generic Ack as writeAck input * Simplify Ack trait * Process write ack using conversion to generic Ack * Allow `packet_callback()` to emit IbcEvents Co-authored-by: hu55a1n1 <sufialhussaini@gmail.com>
I found the handling of
writeAcknowledgement
in the read spec, and it seems that there is no handling ofwriteAknowledgement
in ibc-rsSummary of Bug
For Admin Use
The text was updated successfully, but these errors were encountered: