Refactor ValidationContext
and ExecutionContext
#325
Labels
A: breaking
Admin: breaking change that may impact operators
ValidationContext
and ExecutionContext
#325
Comes out of a comment by @Farhad-Shabani and ensuing sync discussion. We still need to figure out the details, but a main point of confusion was that
validate()
was in theContext
trait; it's not clear from a first look that all the methods in theContext
are used in thevalidate()
function. We can also think of different ways to separate the methods into a few different traits if that helps with readability, and doesn't duplicate methods.Blocked on #221.
Below is the original comment:
Originally posted by @Farhad-Shabani in #221 (comment)
Is it right that we have a tailored validation and execution function for each of the messages like
MsgCreateClient
,MsgUpdateClient
, etc.?Couldn’t we use the following pattern (as a general concept) and implement them on each message type?
It looks more modular, maintainable, and extensible if it works! (please direct me to the places if I am missing something. tnx)
The text was updated successfully, but these errors were encountered: