Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to domain event type for the upgrade_client_proposal_handler return #838

Closed
Farhad-Shabani opened this issue Aug 22, 2023 · 0 comments · Fixed by #790
Closed

Switch to domain event type for the upgrade_client_proposal_handler return #838

Farhad-Shabani opened this issue Aug 22, 2023 · 0 comments · Fixed by #790
Assignees
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Problem Statement

The upgrade_client_proposal_handler function currently returns an event type from the tendermint_proto which starting from tendermint-rs v0.33.0 will be only compatible with CometBFT v0.38.
The tendermint-proto now provides support for multiple versions of CometBFT. So to ensure the handler compatibility with different versions and avoid making assumptions about hosts, the return type should be modified to tendermint::abci::Event. This allows for easy conversion to any version of proto events, allowing for compatibility with different hosts.

@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Aug 22, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Aug 22, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Aug 23, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.45.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant