-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and completed Path; added query to Chain trait; refactored query code into TendermintChain #174
Conversation
…nted it for Tendermint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Left a few suggestions for future consideration but nothing blocking the merge :)
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
========================================
+ Coverage 13.6% 15.6% +1.9%
========================================
Files 69 58 -11
Lines 3752 3720 -32
Branches 1374 1429 +55
========================================
+ Hits 513 582 +69
+ Misses 2618 2430 -188
- Partials 621 708 +87
Continue to review full report at Codecov.
|
… query code into TendermintChain (informalsystems#174) * Refactored and completed Path * added query to Chain trait and implemented it for Tendermint
Closes: #157
Closes: #172
Closes: #173
Description
Apologies for the monstre changes again, but the changes are unfortunately dependent on each other.
Tests are lacking, but maybe soon, in another issue. (Local execution worked.)
For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer