Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error message #30

Open
greg-szabo opened this issue May 9, 2022 · 2 comments
Open

Confusing error message #30

greg-szabo opened this issue May 9, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request multisig Multisig tool

Comments

@greg-szabo
Copy link
Member

Michael was trying to broadcast a test message from a 3-of-5 multisig address. The command should obviously fail, because he didn't sign it and it was just a test. But the error message was misleading:

Error: Insufficient signatures for broadcast. Requires 2, got 0

Michael's correct response:

This one actually requires three…
@andynog
Copy link
Contributor

andynog commented May 10, 2022

This message is confusing because the signature threshold is hard-coded in the code to, it's set to '2'. There's a TODO message saying that the threshold should be part of the config

// TODO: add this to the key config so its not hardcoded to 2.

@greg-szabo
Copy link
Member Author

This is related to informalsystems/validator#246
. Close it when that's done.

@andynog andynog self-assigned this Nov 17, 2022
@andynog andynog added the enhancement New feature or request label Nov 17, 2022
@andynog andynog added this to the multisig v0.4.0 milestone Nov 17, 2022
@andynog andynog added the multisig Multisig tool label Nov 17, 2022
@mircea-c mircea-c assigned mircea-c and unassigned andynog Jun 23, 2023
@mircea-c mircea-c removed this from the multisig - v0.5.0 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multisig Multisig tool
Projects
None yet
Development

No branches or pull requests

3 participants