Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Implement ValidationContext::host_consensus_state() for IbcExecutionContext #7

Closed
Tracked by #883 ...
plafer opened this issue Sep 22, 2023 · 3 comments · Fixed by #101
Closed
Tracked by #883 ...

Implement ValidationContext::host_consensus_state() for IbcExecutionContext #7

plafer opened this issue Sep 22, 2023 · 3 comments · Fixed by #101
Assignees
Labels
modules Related to ibc modules

Comments

@plafer
Copy link
Contributor

plafer commented Sep 22, 2023

Before we can implement this, @preston-evans98 needs to define the protobuf definition of a SovereignConsensusState that represents sovereign SDK chains.

Once that's done, we can implement the method by

  1. querying the relevant parts of our state
  2. construct a SovereignConsensusState and return it
@preston-evans98
Copy link
Contributor

Thanks for the heads up @plafer. Can you link any docs to help me understand exactly what guarantees ConsensusState needs to provide?

@plafer
Copy link
Contributor Author

plafer commented Sep 26, 2023

Sure!

  • Our ConsensusState trait that all consensus states implement
    • To be clear, our "domain type" (which is derived from the "raw" generated protobuf type) is what implements this trait
    • In the Sovereign's case, root() would return the rollup's root. I guess we'd never need access to the DA's root (other than when we're updating the client, which isn't done using this interface).
  • The protobuf definition of the Tendermint ConsensusState
    • Probably useful as an example
  • Official docs on ConsensusState
    • This is just extra; the IBC standard isn't always up to date nor very clear

Let me know if you need anything else

@preston-evans98
Copy link
Contributor

This is perfect, thanks a ton!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
modules Related to ibc modules
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants