Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all crates to Rust edition 2021 #1262

Closed
romac opened this issue Jan 27, 2023 · 0 comments · Fixed by #1261
Closed

Update all crates to Rust edition 2021 #1262

romac opened this issue Jan 27, 2023 · 0 comments · Fixed by #1261
Assignees
Labels
enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Jan 27, 2023

Description

The 2021 edition of the Rust language has been out for a couple years now and enables a bunch of new features and idioms that make the code clearer and often shorter (see the link above for more details).

As part of fixing the new clippy warnings emitted in Rust 1.67, which was released today, I noticed a bunch of our crates are still on edition 2018, which makes it impossible to fix the warnings without outright ignoring them. The tendermint crate and a couple others are already on edition 2021.

I would therefore suggest we update all crates to use edition 2021.

Definition of "done"

All crates in the repository use the 2021 edition of the Rust language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant