Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce app_hash field in testgen Header #1343

Closed
Farhad-Shabani opened this issue Aug 29, 2023 · 0 comments · Fixed by #1344
Closed

Introduce app_hash field in testgen Header #1343

Farhad-Shabani opened this issue Aug 29, 2023 · 0 comments · Fixed by #1344
Labels
enhancement New feature or request

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Aug 29, 2023

Description

Currently, when generating a new Tendermint header from a testgen Header, the app_hash field is set to an empty string value. This leads to a nil root when using this header to obtain consensus states (e.g. like here in basecoin-rs), which is not an acceptable value for ibc-rs implementation, resulting in the rejection of submitted consensus states to an IBC module.

Definition of "done"

To address this, it is recommended to add an app_hash field to the testget Header. While the default value can remain empty, this would allow users the flexibility to introduce their desired app_hash when necessary, as used here for implementing a mock cosmos chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant