Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: Deserializing /block_results with empty JSON consensus_param_updates fails #1440

Closed
ljoss17 opened this issue Jul 11, 2024 · 0 comments · Fixed by #1441
Closed

rpc: Deserializing /block_results with empty JSON consensus_param_updates fails #1440

ljoss17 opened this issue Jul 11, 2024 · 0 comments · Fixed by #1441
Labels
bug Something isn't working

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jul 11, 2024

What went wrong?

If the /block_results response has an empty JSON object for the consensus_param_updates instead of null, the deserialization will fail.

  • {"consensus_param_updates": {}}: fails
  • {"consensus_param_updates": null}: succeeds, setting consensus_param_updates to None

Definition of "done"

Deserializing an empty JSON object should also result in consensus_param_updates being None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ljoss17