Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way of creating a rpc::Client without performing a health check #168

Closed
romac opened this issue Mar 10, 2020 · 1 comment
Closed

Add way of creating a rpc::Client without performing a health check #168

romac opened this issue Mar 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Mar 10, 2020

In the ibc-rs crate, we need to create a rpc::Client in a non-async context in order to store it for later use within a struct, and having rpc::Client::new perform an async health check on creation makes this impossible without spawning an executor, and executing the task returned by new.

I would suggest renaming the existing method to new_healthy and adding a plain new method which does not perform a health check.

@liamsi
Copy link
Member

liamsi commented Mar 10, 2020

resolved in #169

@liamsi liamsi closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants