-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research and implement tarpaulin instead of grcov #252
Comments
related: #250 |
I'm assuming this will be superseded by #811? |
Since our code coverage seems broken (and seems like it has been broken for some time), we should consider fixing it or integrating tarpaulin-based coverage calculation sooner rather than later. @romac are you planning on taking #811 further? What are the pros/cons at this point of going with |
I wish I could but I don't have the bandwidth at the moment.
Pros:
The wrapper itself is marked as experimental, but it basically only wraps |
By the way, we use tarpaulin on ibc-rs but have seen no real improvements (eg. the coverage still jumps around by 30% sometimes, etc) hence why I was looking into source-based code coverage. |
Currently superseded by #840. We can reopen this issue again in future if we want to reconsider using tarpaulin. |
Not a done deal, but according to Tony, tarpaulin has less false negatives.
https://github.com/xd009642/tarpaulin
The text was updated successfully, but these errors were encountered: