Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Clippy and fix badges #39

Closed
liamsi opened this issue Sep 22, 2019 · 1 comment · Fixed by #40
Closed

Enable Clippy and fix badges #39

liamsi opened this issue Sep 22, 2019 · 1 comment · Fixed by #40

Comments

@liamsi
Copy link
Member

liamsi commented Sep 22, 2019

I've noticed that the badges in the readme still point to those of the kms (license, build).

Also, I think it would be a good idea to enable clippy in circle-ci. The kms repo has an example on howto do so:
https://github.com/tendermint/kms/blob/3b3aabf8eab64959dad29ee2d5b747dc5fe813ac/.circleci/config.yml#L16-L20

@liamsi liamsi changed the title Clippy and badges Enable Clippy and fix badges Sep 22, 2019
@xla
Copy link
Contributor

xla commented Sep 23, 2019

On that note I'd suggest to enable pedantic clippy checks as it helps esp. with overflows and precision loss for numbers. For someone interested in hardmode:

#![deny(missing_docs)]
#![deny(warnings)]
#![forbid(
    clippy::all,
    clippy::cargo,
    clippy::nursery,
    clippy::pedantic,
    clippy::restriction
)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants