Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC client incompatibility with Tendermint 0.32 /block_results endpoint #4

Closed
tarcieri opened this issue Aug 1, 2019 · 3 comments
Closed

RPC client incompatibility with Tendermint 0.32 /block_results endpoint #4

tarcieri opened this issue Aug 1, 2019 · 3 comments
Labels
go Compatibility with Go code rpc serialization

Comments

@tarcieri
Copy link
Contributor

tarcieri commented Aug 1, 2019

Copying/pasting this from tendermint/tmkms#286 as reported by @devashishdxt

In tendermint/tendermint#3643, tags were changed to events (event now have an event_type and a list of tags). This change will affect RPC calls such as /block_results (https://github.com/tendermint/kms/blob/master/tendermint-rs/src/abci/responses.rs#L71).
@tarcieri tarcieri mentioned this issue Aug 1, 2019
Closed
@liamsi liamsi mentioned this issue Sep 23, 2019
Closed
@ebuchman ebuchman mentioned this issue Dec 31, 2019
Closed
@greg-szabo greg-szabo mentioned this issue Mar 27, 2020
Closed
@ebuchman
Copy link
Member

ebuchman commented Jun 3, 2020

@greg-szabo is this fixed for v0.33? Not sure we'll fix all this stuff for v0.32

@ebuchman ebuchman added rpc go Compatibility with Go code serialization labels Jun 3, 2020
@ebuchman
Copy link
Member

ping @greg-szabo ?

@greg-szabo
Copy link
Member

Hi, sorry I missed the notifications on this. Yes, this is fixed in 0.33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go Compatibility with Go code rpc serialization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tarcieri @ebuchman @greg-szabo