Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on Clippy errors in CI #406

Closed
romac opened this issue Jul 2, 2020 · 2 comments · Fixed by #868
Closed

Fail on Clippy errors in CI #406

romac opened this issue Jul 2, 2020 · 2 comments · Fixed by #868
Assignees
Labels
ci Related to continuous integration

Comments

@romac
Copy link
Member

romac commented Jul 2, 2020

Once as clippy_check, as configured in .github/workflows/rust.yml, with a JSON output that's not very helpful.

Another time as clippy which produces useful annotations. I am not sure where this one comes from.

I suggest removing the clippy_check job, and while we are at it, turn clippy warnings into CI failures (not sure how to do this, since I don't know where this job is actually set up).

@romac romac added the ci Related to continuous integration label Jul 2, 2020
@romac romac changed the title Clippy appears to run twice on CI Clippy runs twice on CI Jul 2, 2020
@liamsi
Copy link
Member

liamsi commented Jul 3, 2020

Another time as clippy which produces useful annotations. I am not sure where this one comes from.

I think the 2nd one is just the output or rather the process that takes the JSON output of the first (the clippy_check action) to annotate the code. But I agree that it would be nice to fail on clippy instead of. Can easily be done by directly calling clippy instead of using the clippy_check action which creates these annotations).

@xla
Copy link
Contributor

xla commented Jul 4, 2020

Related to #193

@xla xla changed the title Clippy runs twice on CI Fail on Clippy errors in CI Jul 7, 2020
@greg-szabo greg-szabo self-assigned this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants