-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
light-client: improve LightStore API #428
Comments
Something else to keep in mind and think hard about when designing the new API/abstraction:
|
Maybe a broader look at the LightStore would include hiding/reducing the dependency on Sled, ie. #430 (comment) |
We should also keep #449 (comment) in mind. |
The current
LightStore
API is a bit underpowered, and forces us to implement ad-hoc method likeget_non_failed
orlatest_trusted_or_verified
to keep the downstream code clean.It would be nice to have a slightly more powerful, perhaps query-based, API that would remove the need for such ad-hoc methods.
Additionally, the sled-based light store should be guarded under a feature flag, in order to plan for potential other databases or just help downstream dependencies avoid the dependency on sled if they don't need it.
The text was updated successfully, but these errors were encountered: