Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement domain types for protobuf-encoded structs #535

Closed
greg-szabo opened this issue Aug 26, 2020 · 1 comment · Fixed by #537 or #571
Closed

Implement domain types for protobuf-encoded structs #535

greg-szabo opened this issue Aug 26, 2020 · 1 comment · Fixed by #537 or #571
Milestone
v0.17.0

Comments

@greg-szabo
Copy link
Member

After merginf #527 to close #504 , the agreed domain types are missing from tendermint-rs.

  • Implement domain types with TryFrom/From protobuf types. This should ease any conversion issues in the long run.
  • Possibly implement a derive macro that indicates for each domain type what their protobuf type is and implements direct .encode and .decode functionality.

Check the notes in #527 for the requirements for domain types.
@greg-szabo greg-szabo added this to the Go v0.34 Compatibility milestone Aug 26, 2020
This was referenced Aug 26, 2020
Merged
Merged
@ebuchman ebuchman mentioned this issue Aug 28, 2020
Closed
@greg-szabo
Copy link
Member Author

This was done in #537 that was merged into #527 first. Then #527 was merged into master today.

@ebuchman ebuchman mentioned this issue Oct 8, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.0
1 participant
@greg-szabo