-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: expose server-related fields #625
Comments
Hey, is it correct to say that these are the only changes necessary? |
Those are the only one I need at the moment in order to expose the interface I'm interested in, but ideally I would expect all the fields of all the I can create a PR that makes all of them public if needed. |
No problem @CharlyCst! Thought I'd just implement it quickly. Mind taking a look at #636 and seeing if that'll meet your needs? |
Yes that's perfect, thank you! |
Hi,
If my understanding is correct, the RPC crate has been design with the goal of exposing types needed by clients to communicate with nodes, and thus hides server-related details.
This is reflected in multiple places, for instance in the endpoints where the fields of
Response
are public whereas those ofRequest
are private.However, I'm coming up with the opposite use case: I'm building a mocked node in order to test a client. With the current interface of the RPC crate I'm indeed able to deserialize incoming requests, but I can't access the fields to return a plausible response.
Would it be an option to expose server-related structs and fields to cover both client and server needs?
The text was updated successfully, but these errors were encountered: