Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of documentation on docs.rs #807

Merged
merged 8 commits into from
Feb 10, 2021
Merged

Fix rendering of documentation on docs.rs #807

merged 8 commits into from
Feb 10, 2021

Conversation

romac
Copy link
Member

@romac romac commented Feb 10, 2021

Closes: #806

Also adds a workflow to build docs on nightly (with same config as docs.rs).

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

thanethomson
thanethomson approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📖 🎉

@thanethomson thanethomson merged commit e964b1a into master Feb 10, 2021
@thanethomson thanethomson deleted the romac/fix-lc-docs branch February 10, 2021 20:59
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for 0.18.0 failed to build on docs.rs
2 participants
@romac @thanethomson