Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS support for Light Client #835

Closed
thanethomson opened this issue Mar 25, 2021 · 0 comments · Fixed by #842
Closed

TLS support for Light Client #835

thanethomson opened this issue Mar 25, 2021 · 0 comments · Fixed by #842
Assignees
Labels
enhancement New feature or request light-client Issues/features which involve the light client light-node rpc

Comments

@thanethomson
Copy link
Contributor

At the moment, the Light Client makes use of tendermint::net::Address to keep track of RPC addresses, but this doesn't allow for the full range of RPC functionality introduced in #820 (e.g. TLS and proxy support).

We should update the Light Client to use the new URL type, since it's not really peer addresses the Light Client's interested in, but their RPCs' URLs.

Some preliminary work was done in this commit, but I had to roll it back because it broke the WASM build.

What's the definition of "done" for this issue?

Once we can successfully run the Light Node against nodes with secure endpoints (i.e. HTTPS).

@thanethomson thanethomson added enhancement New feature or request light-client Issues/features which involve the light client rpc light-node labels Mar 25, 2021
@thanethomson thanethomson self-assigned this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request light-client Issues/features which involve the light client light-node rpc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant