Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure in CI when deserializing consensus state vote summaries #836

Closed
thanethomson opened this issue Mar 25, 2021 · 0 comments · Fixed by #837
Closed

Intermittent failure in CI when deserializing consensus state vote summaries #836

thanethomson opened this issue Mar 25, 2021 · 0 comments · Fixed by #837
Assignees
Labels
bug Something isn't working rpc serialization

Comments

@thanethomson
Copy link
Contributor

The most recent example of this is here: https://github.com/informalsystems/tendermint-rs/pull/834/checks?check_run_id=2192937025

I've managed to figure out that sometimes the vote type is encoded as a number (1 or 2), and sometimes it's encoded as a string (SIGNED_MSG_TYPE_PREVOTE), and the code currently only caters for the former.

Steps to reproduce

Try deserializing the string causing the CI failure:

Vote{0:2DA21E474F57 384/00/SIGNED_MSG_TYPE_PREVOTE(Prevote) 8FA9FD23F590 2987C33E8F87 @ 2021-03-25T12:12:03.693870115Z}

What's the definition of "done" for this issue?

When we can parse these kinds of vote summaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc serialization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant