Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Secp256k1 signature verification for PublicKey #939

Closed
lyqingye opened this issue Jul 24, 2021 · 3 comments · Fixed by #962
Closed

Support Secp256k1 signature verification for PublicKey #939

lyqingye opened this issue Jul 24, 2021 · 3 comments · Fixed by #962
Assignees
Labels
crypto enhancement New feature or request
Milestone

Comments

@lyqingye
Copy link

I hope Publickey can support the verification of secp256 publickey signature
https://github.com/informalsystems/tendermint-rs/blob/master/tendermint/src/public_key.rs#L151

I think the issue: informalsystems/hermes#1155 is related to this
When some chains use secp256k1 as the consensus PublicKey type, the tendermint-light-client will not be able to verify the signature of the light block, such as bandchain.

@lyqingye lyqingye added the enhancement New feature or request label Jul 24, 2021
@thanethomson thanethomson self-assigned this Jul 27, 2021
@thanethomson thanethomson added this to the Q3 2021 milestone Jul 27, 2021
@RiccardoM
Copy link

Hey @thanethomson, is it possible to have an update on this? It is currently blocking informalsystems/hermes#1155 which actually makes it impossible to communicate with some chains like Band Protocol

@romac romac self-assigned this Aug 25, 2021
@romac
Copy link
Member

romac commented Aug 25, 2021

@RiccardoM I have a WIP branch which adds support for ECDSA Secp256k1 signatures. Will try to include in the next Hermes release.

@tony-iqlusion
Copy link
Collaborator

Happy to help review PRs for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants